Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ethereum token transfer processor #839

Open
wants to merge 4 commits into
base: agustin-ethereum-token-transfers-pallet
Choose a base branch
from

Conversation

dimartiro
Copy link
Contributor

@dimartiro dimartiro commented Feb 3, 2025

Description

Add procesor for ethereum incoming native token transfers + tests

Summary

  • Introduce TokenTransferMessageProcessor to process the incoming token transfer messages from ethereum
    • Exhaustively check message to ensure we can process it
    • Process message, move money from sovereign -> destination account
  • Tests

The logic to reward the relayer will be addressed in a different issue https://opslayer.atlassian.net/browse/MD-868

@dimartiro dimartiro force-pushed the diego-inbound-eth-token-transfer branch from 86b913f to 16ae887 Compare February 3, 2025 02:57
Copy link
Contributor

github-actions bot commented Feb 3, 2025

WASM runtime size check:

Compared to target branch

dancebox runtime: 1420 KB (no changes) ✅

flashbox runtime: 824 KB (no changes) ✅

dancelight runtime: 2184 KB (+2184 KB) ⚠️

container chain template simple runtime: 1124 KB (-4296 KB) ✅

container chain template frontier runtime: 1400 KB (-5152 KB) ✅

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Coverage Report

(master)

@@                                          Coverage Diff                                          @@
##           agustin-ethereum-token-transfers-pallet   diego-inbound-eth-token-transfer      +/-   ##
=====================================================================================================
+ Coverage                                    66.04%                             66.14%   +0.10%     
+ Files                                          335                                339       +4     
+ Lines                                        58858                              59231     +373     
=====================================================================================================
+ Hits                                         38869                              39176     +307     
+ Misses                                       19989                              20055      +66     
Files Changed Coverage
/chains/orchestrator-paras/runtime/common/src/migrations.rs 86.23% (+0.67%)
/chains/orchestrator-relays/runtime/dancelight/src/bridge_to_ethereum_config.rs 86.49% (+29.35%)
/chains/orchestrator-relays/runtime/dancelight/src/lib.rs 68.80% (+0.19%)
/chains/orchestrator-relays/runtime/dancelight/src/tests/migrations_test.rs 97.47% (-1.57%)
/pallets/external-validator-slashes/src/lib.rs 86.03% (-0.22%)
/pallets/external-validators/src/lib.rs 90.44% (-0.41%)
/primitives/bridge/src/symbiotic_message_processor.rs 92.86% (-0.69%)

Coverage generated Wed Feb 5 00:47:18 UTC 2025

@dimartiro dimartiro added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited breaking Needs to be mentioned in breaking changes labels Feb 3, 2025
@dimartiro dimartiro self-assigned this Feb 4, 2025
@dimartiro dimartiro marked this pull request as ready for review February 5, 2025 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant