Test xcm message export is disabled #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimartiro
added
B0-silent
dimartiro
force-pushed
the
diego-test-disabled-message-exporter
branch
from
6bda0f5 to
9ae35c9
Compare
WASM runtime size check:Compared to target branchdancebox runtime: 1420 KB (no changes) ✅ flashbox runtime: 824 KB (no changes) ✅ dancelight runtime: 2168 KB (no changes) ✅ container chain template simple runtime: 1124 KB (no changes) ✅ container chain template frontier runtime: 1400 KB (no changes) ✅ |
Coverage Report@@ Coverage Diff @@
## master diego-test-disabled-message-exporter +/- ##
========================================================================
+ Coverage 65.76% 65.80% +0.04%
+ Files 332 333 +1
+ Lines 58501 58544 +43
========================================================================
+ Hits 38472 38522 +50
- Misses 20029 20022 -7
|
tmpolaczyk
approved these changes
Jan 22, 2025
tmpolaczyk
reviewed
Jan 22, 2025
chains/orchestrator-relays/runtime/dancelight/src/tests/common/xcm/xcm_message_exporter.rs
Outdated
Show resolved
Hide resolved
girazoki
approved these changes
Jan 24, 2025
dimartiro
force-pushed
the
diego-test-disabled-message-exporter
branch
from
0d81c23 to
e5329e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test that the XCM
MessageExporteris disabled for dancelight.Since we are setting
ExecuteXcmOriginasEnsureXcmOrigin<RuntimeOrigin, LocalOriginToLocation>, the onlytest we can do is with a signed
AccountIdas the origin.I'm open to suggestions if there are more test cases to add 🙌