Skip to content

Commit

Permalink
Add new release instructions and fix wrong job (#866)
Browse files Browse the repository at this point in the history
  • Loading branch information
girazoki authored Feb 13, 2025
1 parent d058a20 commit 67bda97
Show file tree
Hide file tree
Showing 6 changed files with 59 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/docker-runtime-draft.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
- name: Upload binaries
uses: actions/upload-artifact@v4
with:
name: binaries-${{ matrix.chain.cpu }}
name: binaries-${{ matrix.cpu }}
path: binaries
docker-tanssi:
runs-on: ubuntu-latest
Expand All @@ -67,7 +67,7 @@ jobs:
uses: actions/checkout@v4
- uses: actions/download-artifact@v4
with:
pattern: binaries-${{ matrix.chain.cpu }}
pattern: binaries-*
merge-multiple: true
path: build
- name: Prepare
Expand Down
32 changes: 32 additions & 0 deletions .github/workflows/publish-docker-runtime-tanssi-solochain.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
name: Publish Docker runtime tanssi-solochain

on:
workflow_dispatch:
inputs:
tag:
description: runtime tag (ex. runtime-2200-startlight) to publish on docker
required: true

jobs:
tag-docker:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Login to DockerHub
uses: docker/[email protected]
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
- name: Publish runtime docker image
run: |
DOCKER_IMAGE=moondancelabs/starlight
DOCKER_TAG="${{ github.event.inputs.tag }}"
COMMIT=`git rev-list -n 1 '${{ github.event.inputs.tag }}'`
SHA=sha-${COMMIT::8}
echo tagging "${DOCKER_IMAGE}:${SHA}"
docker pull "${DOCKER_IMAGE}:${SHA}"
docker tag "${DOCKER_IMAGE}:${SHA}" "${DOCKER_IMAGE}:${DOCKER_TAG}"
docker push "${DOCKER_IMAGE}:${DOCKER_TAG}"
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Publish Docker Dancelight
name: Publish Docker Solochain

on:
workflow_dispatch:
Expand Down
8 changes: 8 additions & 0 deletions tools/github/print-client-release-issue.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,22 @@ async function main() {
const commonTemplate = `
- [ ] Start the github action Publish Binary Draft with ${previousVersion} => ${newVersion}
(master branch).
- [ ] Start the github action Publish Dancelight Binary Draft with ${previousVersion} => ${newVersion}
(master branch).
- [ ] Review the generated Draft and clean a bit the messages if needed (keep it draft).
- [ ] Start the internal optimized binary build by starting the github action Prepare Optimized Binary Draft with the commit of ${previousVersion} (mster branch)
- [ ] Start the internal optimized binary build by starting the github action Prepare Optimized Dancelight Binary Draft with the commit of ${previousVersion} (mster branch)
- [ ] Update chain-networks stagenet-dancebox config.json to include sha-xxxxx built from the optimized binary and pushed to docker
(matching your ${newVersion} tag) and increase the config version + 1.
- [ ] Update chain-networks stagelight config.json to include sha-xxxxx built from the optimized binary and pushed to docker
(matching your ${newVersion} tag) and increase the config version + 1.
- [ ] Test the new client on stagenet-dancebox.
- [ ] Test the new client on stagelight.
- [ ] Publish the client release draft.
- [ ] When everything is ok, publish the new docker image: start github action Publish Docker
with ${newVersion}.
- [ ] When everything is ok, publish the new docker image: start github action Publish Docker Dancelight
with ${newVersion}.
`;

// Detect if it's a major release or hotfix
Expand Down
20 changes: 16 additions & 4 deletions tools/github/print-runtime-release-issue.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,27 @@ async function main() {
- [ ] Re-run all extrinsics/hooks benchmarks.
- [ ] Branch from master and create branch \`perm-runtime-${newVersion}\`.
- [ ] Tag \`perm-${newVersion}\` with runtime-${newVersion} and push to github
- [ ] Branch from master and create branch \`perm-runtime-${newVersion}-templates\`.
- [ ] Tag \`perm-runtime-${newVersion}-templates\` with runtime-${newVersion}-templates and push to github
- [ ] Tag \`perm-runtime-${newVersion}\` with runtime-${newVersion}-templates and push to github
- [ ] Tag \`perm-runtime-${newVersion}\` with runtime-${newVersion}-starlight and push to github
- [ ] NOTE: if this is a hotfix to one of the runtimes, branch from runtime-${previousVersion} version
and create perm-runtime-${newVersion}-templates, perm-runtime-${newVersion}-starlight or perm-runtime-${newVersion}-tanssi
depending on whether the hotfix is for templates, starlight or tanssi-parachain. Then tag accordingly
- [ ] Start the github action Publish Runtime Draft
with runtime-${previousVersion} => runtime-${newVersion}
- \`gh workflow run "Publish Runtime Draft" -r 'master' ` +
`-f from=runtime-${previousVersion} -f to=runtime-${newVersion} -f chains=run-all\`
`-f from=runtime-${previousVersion} -f to=runtime-${newVersion} -f chains=tanssi-only\`
- [ ] Start the github action Publish Runtime Draft
with runtime-${previousVersion} => runtime-${newVersion}
- \`gh workflow run "Publish Runtime Draft" -r 'master' ` +
`-f from=runtime-${previousVersion} -f to=runtime-${newVersion} -f chains=templates-only\`
- [ ] Start the github action Publish Runtime Draft
with runtime-${previousVersion} => runtime-${newVersion}
- \`gh workflow run "Publish Runtime Draft" -r 'master' ` +
`-f from=runtime-${previousVersion} -f to=runtime-${newVersion} -f chains=dancelight-only\`
- [ ] Review the generated Draft and clean a bit the messages if needed (keep it draft)
- [ ] Upgrade typescript API: Start the github action "Upgrade typescript API"
- [ ] Upgrade stagenet-dancebox
- [ ] Upgrade stagelight
- [ ] When everything is ok, publish the draft release
`;

Expand All @@ -68,7 +80,7 @@ ${commonTemplate}
- [ ] Publish the docker runtime image (trigger the github action "Publish Docker runtime containers")
- \`gh workflow run "Publish Runtime Draft" -r 'master' ` +
`-f from=runtime-${previousVersion}-templates -f to=runtime-${newVersion}-templates\`
- [ ] Create a PR that increment spec version (like #1051) in both containers and tanssi runtimes
- [ ] Create a PR that increment spec version (like #1051) in both containers, tanssi and starlight runtimes
`;
console.log(template);
} else {
Expand Down

0 comments on commit 67bda97

Please sign in to comment.