-
Notifications
You must be signed in to change notification settings - Fork 122
extend assert functions by add fail_msg~ argument #2172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Inconsistent string interpolation usage in default messagesCategory Redundant string conversion removed but behavior changedCategory Documentation needs update to reflect new parameterCategory /// # Examples
/// ```
/// assert_true(1 == 1)
/// assert_true(1 == 1, "Custom error message")
/// ```
**Reasoning**
The documentation examples don't show the new fail_msg parameter usage. Adding examples would help users understand how to use the new functionality.
</details> |
d803a73
to
b6be526
Compare
Pull Request Test Coverage Report for Build 7009Details
💛 - Coveralls |
b6be526
to
733e691
Compare
if not(x) { | ||
fail("`\{x}` is not true", loc~) | ||
fail(fail_msg, loc~) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the default is empty
4455c18
to
c52556c
Compare
ef44c50
to
25a0dfd
Compare
use case: calling assert_true/assert_false in for loop unicode test