Add Array::windows

[MINGtoMING]

Add Array::windows.

[peter-jerry-ye-code-review]

No validation for negative window size

Category
Correctness
Code Snippet
pub fn Array::windows[T](self : Array[T], size : Int) -> Array[ArrayView[T]]
Recommendation
Add validation to handle negative window sizes by either throwing an error or returning an empty array:

if size <= 0 {
  return []
}

Reasoning
The documentation states size must be positive, but the implementation doesn't enforce this. Negative sizes could cause unexpected behavior or runtime errors.

Test cases could be more comprehensive

Category
Maintainability
Code Snippet
test "array_windows" {
let arr = [1, 2, 3, 4, 5, 6]
let windows = arr.windows(11)
...
}
Recommendation
Add test cases for:

• Empty input array
• Window size of 0
• Negative window size
• Window size equal to array length
  Reasoning
  Current tests don't cover all edge cases that could reveal potential issues. More comprehensive testing ensures robustness.

Potential memory optimization for large arrays

Category
Performance
Code Snippet
let windows = Array::new(capacity=len)
for i in 0..<len {
windows.push(self[i:i + size])
}
Recommendation
Consider implementing lazy evaluation or iterator pattern for large arrays where all windows aren't needed immediately
Reasoning
Current implementation eagerly creates all window slices, which could be memory-intensive for large arrays when only a few windows are actually needed

[coveralls]

Pull Request Test Coverage Report for Build 6907

Details

• 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.003%) to 92.457%

---

Totals
Change from base Build 6906:	0.003%
Covered Lines:	8691
Relevant Lines:	9400

---

💛 - Coveralls

[FlyCloudC]

How about return an Array[ArrayView[T]]?

[MINGtoMING]

I agree. Array::windows is typically used in read-only scenarios as well. However, the func interface differs from existing chunks/chunk_by impl, so perhaps they need to be adjusted together.