Features/cache packages (Install from cache if offline) #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because we trust our input, and don't want the HTML escaping inside CSS and Javascript templates.
To replace singleton with a class, and wrap methods in promises
tejaede
requested changes
Dec 7, 2017
| @@ -68,7 +68,6 @@ var create = module.exports = function(templateName, config, templateModule) { | |||
| }); | |||
|
|
|||
| }; | |||
| exports.create = create; | |||
There was a problem hiding this comment.
Either this needs to be reinstated or line 82 needs to be updated to use create instead of exports.create
Line 82 in 36c4359
|
@hthetiot I am unable to create an application with either node 4.8 or 8.9 due to the line I reviewed above in create.js. I briefly fixed that locally and found that I can create an app, but it is not clear to me how to appropriately test the install-while-offline functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.