Skip to content

chore: upgrade pull-request workflow from @v2 to @main#41

Merged
morten-andersen merged 5 commits intomainfrom
chore/upgrade-pull-request-v2-to-main
Feb 11, 2026
Merged

chore: upgrade pull-request workflow from @v2 to @main#41
morten-andersen merged 5 commits intomainfrom
chore/upgrade-pull-request-v2-to-main

Conversation

@JesperTerkelsen
Copy link
Member

Summary

Updates pull-request.yaml@v2pull-request-kotlin.yml@main in github-workflows.

Changes:

  • pull-request.yaml was renamed/replaced by pull-request-kotlin.yml on main (uses Kover for coverage instead of Jacoco)
  • Adds SONAR_TOKEN to enable SonarCloud analysis (org secret, previously not configured)

Other improvements on main: Java 21 default, gradle multi-module support, ktlint, test result publishing, PR title check.

Test plan

  • Verify PR checks trigger and pass on this PR

🤖 Generated with Claude Code

Updates pull-request.yaml@v2 → pull-request-kotlin.yml@main.
Adds SONAR_TOKEN to enable SonarCloud analysis.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@JesperTerkelsen JesperTerkelsen requested a review from a team as a code owner February 10, 2026 19:03
@github-actions
Copy link

github-actions bot commented Feb 10, 2026

Test Results

123 tests   123 ✅  10s ⏱️
 24 suites    0 💤
 24 files      0 ❌

Results for commit 465d579.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@morten-andersen morten-andersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kover is not set up for this lib

@JesperTerkelsen
Copy link
Member Author

Perhaps i should add kover coverage here then ?

JesperTerkelsen and others added 4 commits February 10, 2026 22:05
Adds the Kover plugin to enable code coverage reporting,
required by the upgraded pull-request-kotlin.yml@main workflow.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fixes dependency resolution issue where Kover couldn't resolve
kotlin-bom from the root project's koverExternalArtifacts config.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Points to core module's coverage report since Kover runs
per-submodule rather than at the root.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link

Code Coverage

Total Project Coverage 3.51%

@morten-andersen morten-andersen merged commit c5d1203 into main Feb 11, 2026
5 checks passed
@morten-andersen morten-andersen deleted the chore/upgrade-pull-request-v2-to-main branch March 19, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants