Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little ops #310

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

Little ops #310

wants to merge 9 commits into from

Conversation

Yankow2
Copy link

@Yankow2 Yankow2 commented Jan 23, 2018

I have added two operators:

  • Route2 is mostly practical as a small operator to be used mostly with List2 (it is just logical, and saves some space in many case).
  • Hist2 could be called Switch, actually: it is a small History operator with one input and two outputs (0 and 1, no average).

I have been using these two for quite a while on my own, and they have proven very useful in bigger scenes mostly - think some others might think the same. Also, it will help me to share some of my scenes, which use those.

By the way, why not change the name Route for Route4, now that we have List2, List4, List8, List16, and then Route2, Route, Route8 and Route16?

@catfact catfact self-requested a review January 24, 2018 01:16
Copy link
Collaborator

@catfact catfact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple typos broke compilation for me.

@@ -60,7 +60,8 @@ CSRCS += \
$(APP_DIR)/src/ops/op_fade.c \
$(APP_DIR)/src/ops/op_gate.c \
$(APP_DIR)/src/ops/op_harry.c \
$(APP_DIR)/src/ops/op_hid_word.c \
$(APP_DIR)/src/ops/op_hid_word.c \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this tab breaks Make

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no clue about what is wrong here, but after copying the original version (and again I don't see any difference) it seems to work correctly for me. Therefore I replaced config.mk with the version I had in my computer.

@@ -69,6 +70,7 @@ const op_id_t userOpTypes[NUM_USER_OP_TYPES] = {
eOpPoly,
eOpRandom,
eOpRoute,
eOpRoute2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this missing comma breaks compilation

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stupid mistake, sorry about that... It is my first time in here (and I am well aware I am replying to this two months later), and instead of copying my code I rewrote it into github, hence the errors. Now how should this work? I am fine with correcting these of course, but should I do the changes myself or should I simply accept yours?

@catfact
Copy link
Collaborator

catfact commented Jan 24, 2018

i'm down with renaming ROUTE to ROUTE4 for consistency, both in display and class/enum. shouldn't even break any scenes if order of op class enum/registry remains unchanged.

Yankow2 added 4 commits April 15, 2018 13:03
corrected line 73, coma missing
Coma missing in line 73 - corrected
Should be fixed by now
Copy link
Author

@Yankow2 Yankow2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should go for ROUTE4 then, I am quite bad at working with Github so far but learning... Hope it is all good now, as soon as the changes are in I will post a few scenes for Bees 0.8.1 (or 0.8.2?)

@@ -69,6 +70,7 @@ const op_id_t userOpTypes[NUM_USER_OP_TYPES] = {
eOpPoly,
eOpRandom,
eOpRoute,
eOpRoute2
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stupid mistake, sorry about that... It is my first time in here (and I am well aware I am replying to this two months later), and instead of copying my code I rewrote it into github, hence the errors. Now how should this work? I am fine with correcting these of course, but should I do the changes myself or should I simply accept yours?

@@ -60,7 +60,8 @@ CSRCS += \
$(APP_DIR)/src/ops/op_fade.c \
$(APP_DIR)/src/ops/op_gate.c \
$(APP_DIR)/src/ops/op_harry.c \
$(APP_DIR)/src/ops/op_hid_word.c \
$(APP_DIR)/src/ops/op_hid_word.c \
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no clue about what is wrong here, but after copying the original version (and again I don't see any difference) it seems to work correctly for me. Therefore I replaced config.mk with the version I had in my computer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants