Fix crash disposing GRContext for Metal backend #3258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy-visionaid
changed the title
jeremy-visionaid
force-pushed
the
grcontext-metal-finalizer
branch
3 times, most recently
from
843e1c5 to
a53ebbd
Compare
AbandonContext appears to destroy the command buffer, causing the finalizer to crash from a double free. Fixes: mono#3178
jeremy-visionaid
force-pushed
the
grcontext-metal-finalizer
branch
from
a53ebbd to
8a1443c
Compare
|
@mattleibow Perhaps this should be handled in gr_direct_context_make_metal instead? |
jeremy-visionaid
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Use NSObject.DangerousRetain to prevent a double free of the command buffer
Bugs Fixed
API Changes
None.
Behavioral Changes
None.
Required skia PR
None.
PR Checklist