Enable Windows linker optimizations in Release #3241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the docs: ``` /DEBUG changes the defaults for the /OPT option from REF to NOREF and from ICF to NOICF, so if you want the original defaults, you must explicitly specify /OPT:REF or /OPT:ICF after the /DEBUG option. ``` Since the scripts enabled DEBUG even in release, those should be reenabled to reduce binary size.
|
Hey there @@MichalPetryka! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
As per the docs:
Since the scripts enabled DEBUG even in release, those should be reenabled to reduce binary size.
No tests due to being a build configuration only change.
Bugs Fixed
libSkiaSharp.dllgets build with/DEBUG:FULLwithout reenabling linker opts #3240API Changes
None.
Behavioral Changes
Possibly slightly regressed debugging experience of release binaries.
Required skia PR
None.
PR Checklist