refactor: move event handlers from simple-modals to respective files (@biplavbarua) #7333
+164
−155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the
TODOinsimple-modals.tsby moving event handlers to their respective page controller files (account-settings.tsandsettings.ts).Key Changes:
.pageAccountSettingshandlers toaccount-settings.ts..pageSettingshandlers tosettings.ts.PopupKey,list, andshowPopuptosimple-modals-base.tsto resolve circular dependencies introduced by importing page controllers insimple-modals.ts(which now importshowPopupfrom base).Testing:
madge.tsc.