Skip to content

fix(event-handlers): commandOverride not working due to incorrect check (@byseif21) #7330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Miodec merged 1 commit into from
Jan 8, 2026
Merged

fix(event-handlers): commandOverride not working due to incorrect check (@byseif21) #7330

Miodec merged 1 commit into from
Jan 8, 2026

Conversation

@byseif21
Copy link
Contributor

@byseif21 byseif21 commented Jan 8, 2026

it returns null when attribute doesn't exist, not undefined

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Jan 8, 2026
Miodec
Miodec approved these changes Jan 8, 2026
View reviewed changes
Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Miodec Miodec merged commit 69cc227 into monkeytypegame:master Jan 8, 2026
14 checks passed
@byseif21 byseif21 deleted the fix/commandOverride branch January 8, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Miodec Miodec Miodec approved these changes

Assignees

No one assigned

Labels

frontend User interface or web stuff

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@byseif21 @Miodec @monkeytypegeorge