-
-
Notifications
You must be signed in to change notification settings - Fork 3k
fix(caret): positioning for mixed language directions in zen (@byseif21) #7281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
byseif21
wants to merge
12
commits into
monkeytypegame:master
Choose a base branch
from
byseif21:fix/zen-caret-mix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+9
−2
Open
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
82540c9
fix(zen): caret positioning for mixed language directions (@byseif21)
byseif21 c1868c7
direction at letter level only in zen, so caret follows mixed RTL/LTR…
byseif21 1dfd966
Merge branch 'master' into fix/zen-caret-mix
byseif21 d03cc56
unneeded fb
byseif21 7aea1a2
Merge branch 'master' into fix/zen-caret-mix
byseif21 130f09e
.
byseif21 86f86b7
refactor move zen logic into getTargetPositionAndWidth & reduce redun…
byseif21 27351ee
Merge branch 'master' into fix/zen-caret-mix
byseif21 54c275c
per letter for custom and polyglot to fix the caret in mixing
byseif21 b374905
naming
byseif21 34350f1
Merge branch 'master' into fix/zen-caret-mix
byseif21 53f5d9f
Merge branch 'master' into fix/zen-caret-mix
Miodec File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.