Skip to content

fix: Resolve build errors, circular dependencies, and config sync loop (@eikomaniac) #7173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Miodec merged 6 commits into from
Dec 1, 2025
Merged

fix: Resolve build errors, circular dependencies, and config sync loop (@eikomaniac) #7173

Miodec merged 6 commits into from
Dec 1, 2025

Conversation

@eikomaniac
Copy link
Collaborator

@eikomaniac eikomaniac commented Dec 1, 2025

Description

  • Break circular dependencies in tribes module by extracting navigate-event.ts and tribe-auto-join.ts
  • Fix TypeScript build and runtime errors across tribes-related files
  • Prevent infinite config sync loop in tribes lobby
    • code quality fixes

@eikomaniac eikomaniac self-assigned this Dec 1, 2025
@monkeytypegeorge monkeytypegeorge added backend Server stuff frontend User interface or web stuff labels Dec 1, 2025
@eikomaniac eikomaniac changed the title Resolve build errors, circular dependencies, and config sync loop fix: Resolve build errors, circular dependencies, and config sync loop Dec 1, 2025
@eikomaniac eikomaniac changed the title fix: Resolve build errors, circular dependencies, and config sync loop fix: Resolve build errors, circular dependencies, and config sync loop (@eikomaniac) Dec 1, 2025
@eikomaniac eikomaniac requested a review from Miodec December 1, 2025 17:07
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Dec 1, 2025
@Miodec Miodec merged commit 4204195 into newtribemerge Dec 1, 2025
10 of 13 checks passed
@github-actions github-actions bot removed the waiting for review Pull requests that require a review before continuing label Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Miodec Miodec Miodec approved these changes

Assignees

@eikomaniac eikomaniac

Labels

backend Server stuff frontend User interface or web stuff

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eikomaniac @Miodec @monkeytypegeorge