Skip to content

feat(theme): add "Item" theme (@jnx03) #6499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

JNX03
Copy link
Contributor

@JNX03 JNX03 commented Apr 28, 2025

Description

Add a brand-new Item theme:

  • Created frontend/static/themes/item/theme.css
  • Updated frontend/static/themes/_list.json to include "item" under available themes
  • Added a preview screenshot at frontend/static/themes/item/screenshot.png

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If it’s a language, did you edit _list.json, _groups.json and add languages.json?
    • If it’s a theme, did you add themes/item/theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org/ for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Here some preview! Hope you like it :D

Screenshot 2025-05-07 222632
Screenshot 2025-05-07 222530
Screenshot 2025-05-07 222548
Screenshot 2025-05-07 222625

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Apr 28, 2025
@Diamonds85
Copy link

Oh my God. I am so so sorry for you. The problem with prettier is there isn't one more new line at the end of the file.

@Diamonds85
Copy link

There should be 146 lines, there needs to be one extra newline at the end of items.css

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ADD NEWLINE, PRETTIER LIKES NEWLINE

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

137th line just one more now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure I try do it

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WHY PRETTIER WHY

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add it but didn't fix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why it didn't work it ry run the command to do prettier many time and even add some 137th line didn't even resolve it. but thank for the suggestion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finnaly resolve it after review the workflow. Thank again @Diamonds85

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what was it?

@Diamonds85
Copy link

YESS PRETTIER FINALLY

@Miodec
Copy link
Member

Miodec commented May 7, 2025

Please add some screenshots

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label May 7, 2025
@JNX03
Copy link
Contributor Author

JNX03 commented May 7, 2025

Sure thing :) give me a moment

@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label May 7, 2025
@JNX03
Copy link
Contributor Author

JNX03 commented May 7, 2025

Here some preview! Hope you like it :D

Screenshot 2025-05-07 222632
Screenshot 2025-05-07 222530
Screenshot 2025-05-07 222548
Screenshot 2025-05-07 222625

@Miodec
Copy link
Member

Miodec commented May 29, 2025

Sorry, looks like a duplicate of catpuccin. Thanks for the PR though.

@Miodec Miodec closed this May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants