-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat(theme): add "Item" theme (@jnx03) #6499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(theme): add "Item" theme (@jnx03) #6499
Conversation
modified: frontend/static/themes/item.css
Oh my God. I am so so sorry for you. The problem with prettier is there isn't one more new line at the end of the file. |
There should be 146 lines, there needs to be one extra newline at the end of items.css |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ADD NEWLINE, PRETTIER LIKES NEWLINE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
137th line just one more now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I try do it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WHY PRETTIER WHY
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I add it but didn't fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why it didn't work it ry run the command to do prettier many time and even add some 137th line didn't even resolve it. but thank for the suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I finnaly resolve it after review the workflow. Thank again @Diamonds85
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what was it?
YESS PRETTIER FINALLY |
Please add some screenshots |
Sure thing :) give me a moment |
Sorry, looks like a duplicate of catpuccin. Thanks for the PR though. |
Description
Add a brand-new Item theme:
frontend/static/themes/item/theme.css
frontend/static/themes/_list.json
to include"item"
under available themesfrontend/static/themes/item/screenshot.png
Checks
_list.json
,_groups.json
and addlanguages.json
?themes/item/theme.css
?@
inside parentheses at the end of the PR title.Here some preview! Hope you like it :D