Skip to content

fix(connection): add jQuery selector for closing offline banner (@AmanWebDev2) #6390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AmanWebDev2
Copy link

@AmanWebDev2 AmanWebDev2 commented Mar 21, 2025

Description

This PR fixes issue #6389, which addresses the problem where the "No internet connection" banner would not disappear even after the user reconnects to the internet. The fix adds a proper jQuery selector that correctly targets the offline banner element with the appropriate classes (psa.notice), ensuring it gets closed when connection is restored.

Additionally, this PR also fixes an issue where, after going offline, if the user manually cancels the offline banner and then reconnects, the 'You're back online' toast message would not appear. The fix ensures the toast message is correctly triggered when the connection is restored.

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #6389

RESULT -

Screen.Recording.2025-03-22.at.02.02.23.mov
Screen.Recording.2025-03-23.at.02.12.37.mp4

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Mar 21, 2025
@Miodec
Copy link
Member

Miodec commented Mar 26, 2025

Additionally, this PR also fixes an issue where, after going offline, if the user manually cancels the offline banner and then reconnects, the 'You're back online' toast message would not appear. The fix ensures the toast message is correctly triggered when the connection is restored.

This was done to not bother the user with 'back online' banners if they alread closed the offline banner, so im not sure about this change.

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend User interface or web stuff waiting for update Pull requests or issues that require changes/comments before continuing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"No internet connection" banner not disappearing even after re-connecting
3 participants