Add missing tests for bulkWrite command #1803
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
…d unacknowledged write concern Co-Authored-By: [email protected] <[email protected]>
devin-ai-integration
bot
requested review from
nbbeeken
and removed request for
a team
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
JamesKovacs
requested changes
May 14, 2025
| namespace: *namespace | ||
| document: { _id: 6, x: 66 } | ||
| verboseResults: false | ||
| ordered: false |
There was a problem hiding this comment.
This should be ordered: true.
| @@ -349,3 +349,64 @@ tests: | |||
| document: { _id: 3, x: 33 } | |||
| nsInfo: | |||
| - ns: *namespace | |||
| - description: "client bulkWrite with unacknowledged write concern (w:0) for all batches" | |||
There was a problem hiding this comment.
Include in the description that this test is expected to return an error.
| @@ -135,3 +135,56 @@ tests: | |||
| - databaseName: *database0Name | |||
| collectionName: *collection0Name | |||
| documents: [] | |||
| - description: "client bulk write delete with non-Int32 hint" | |||
There was a problem hiding this comment.
bulk write should be bulkWrite for consistency with other tests.
…tency Co-Authored-By: [email protected] <[email protected]>
JamesKovacs
reviewed
May 14, 2025
| @@ -349,7 +349,7 @@ tests: | |||
| document: { _id: 3, x: 33 } | |||
| nsInfo: | |||
| - ns: *namespace | |||
| - description: "client bulkWrite with unacknowledged write concern (w:0) for all batches" | |||
| - description: "client bulkWrite with unacknowledged write concern (w:0) for all batches - expected to return an error" | |||
There was a problem hiding this comment.
Indicate that this test involves w:0 with ordered:true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing tests for bulkWrite command
This PR adds tests for:
These tests cover recent changes to the bulk-write specification, specifically:
Changes
Link to Devin run: https://app.devin.ai/sessions/9b320f37d14b47999b5f313aa3df8fe4
Requested by: [email protected]