Skip to content

Conversation

@caesarbell
Copy link
Collaborator

@caesarbell caesarbell commented Oct 20, 2025

Stories/Links:

DOP-6282

Current Behavior:

Put a link to current staging or production behavior, if applicable

Staging Links:

Directly hitting the docs' 404 page for the first time should render the fallback text (no link in copy)

Hitting a site and being redirected to the 404 should render the new copy (including the link), which gets the original requested URL via cookies.

After being redirected, if going directly to the 404 i.e. /docs/404, you will still see the new copy because the cookie is stored for 10 minutes.

Here is an example

DOCS Atlass notice the extra 's'.

Notes:

The designer of the 404 updates reviewed and signed off.

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

@netlify
Copy link

netlify bot commented Oct 20, 2025

Deploy Preview for docs-frontend-stg ready!

Name Link
🔨 Latest commit f98d661
🔍 Latest deploy log https://app.netlify.com/projects/docs-frontend-stg/deploys/68fa8e2c8bb5560008b7784b
😎 Deploy Preview https://deploy-preview-1575--docs-frontend-stg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@docs-builder-bot
Copy link

docs-builder-bot commented Oct 20, 2025

✅ Deploy Preview for atlas ready

Item Details
🔨 Latest Commit 8c5df6a991179658b956b69ff68738f3da36a07a
😎 Deploy Preview https://deploy-preview-1575--docs-frontend-stg.netlify.app/docs/atlas
🔍 Build Logs View Logs

Copy link
Collaborator

@mmeigs mmeigs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good! I'm going to wait to approve until we can fully test :)

@caesarbell
Copy link
Collaborator Author

This looks pretty good! I'm going to wait to approve until we can fully test :)

That works for me, this is why I kept this one in draft. Once I get the work done in B2K, and successfully test it, I will make this ready for review.

@mmeigs
Copy link
Collaborator

mmeigs commented Oct 22, 2025

This looks pretty good! I'm going to wait to approve until we can fully test :)

That works for me, this is why I kept this one in draft. Once I get the work done in B2K, and successfully test it, I will make this ready for review.

Oh ok! I always review when I'm tagged to review, so i was confused

@caesarbell caesarbell requested a review from mmeigs October 22, 2025 18:25
@caesarbell caesarbell marked this pull request as ready for review October 22, 2025 18:25
@caesarbell
Copy link
Collaborator Author

This looks pretty good! I'm going to wait to approve until we can fully test :)

That works for me, this is why I kept this one in draft. Once I get the work done in B2K, and successfully test it, I will make this ready for review.

Oh ok! I always review when I'm tagged to review, so i was confused

Sorry about that. I will keep that in mind. It is ready now tho.

Copy link
Collaborator

@mmeigs mmeigs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing: the spacing of the 404 page is incorrect. It seems far to the right rather than how the Figma shows. Also, the Figma shows keeping the Docs Home button in the ActionBar area.

@caesarbell
Copy link
Collaborator Author

One small thing: the spacing of the 404 page is incorrect. It seems far to the right rather than how the Figma shows. Also, the Figma shows keeping the Docs Home button in the ActionBar area.

My goal was to align it with the action bar's input field, which is also far to the right. I can run this by the designer again, but they did sign off on the changes after reviewing it yesterday. I will also confirm if they want the Docs Home button as well, as that wasn't originally there.

@caesarbell caesarbell requested a review from mmeigs October 23, 2025 15:10
Copy link
Collaborator

@mmeigs mmeigs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spoken about offline: Design said it's good as is!

@caesarbell caesarbell merged commit a469917 into main Oct 23, 2025
7 checks passed
@caesarbell caesarbell deleted the DOP-6282 branch October 23, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants