-
Notifications
You must be signed in to change notification settings - Fork 36
DOP-6282: Introduces the new 404 page w/ original req URL in the body #1575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… original req url
✅ Deploy Preview for docs-frontend-stg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for atlas ready
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good! I'm going to wait to approve until we can fully test :)
That works for me, this is why I kept this one in draft. Once I get the work done in B2K, and successfully test it, I will make this ready for review. |
Oh ok! I always review when I'm tagged to review, so i was confused |
Sorry about that. I will keep that in mind. It is ready now tho. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small thing: the spacing of the 404 page is incorrect. It seems far to the right rather than how the Figma shows. Also, the Figma shows keeping the Docs Home button in the ActionBar area.
My goal was to align it with the action bar's input field, which is also far to the right. I can run this by the designer again, but they did sign off on the changes after reviewing it yesterday. I will also confirm if they want the Docs Home button as well, as that wasn't originally there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spoken about offline: Design said it's good as is!
Stories/Links:
DOP-6282
Current Behavior:
Put a link to current staging or production behavior, if applicable
Staging Links:
Directly hitting the docs' 404 page for the first time should render the fallback text (no link in copy)
Hitting a site and being redirected to the 404 should render the new copy (including the link), which gets the original requested URL via cookies.
After being redirected, if going directly to the 404 i.e.
/docs/404, you will still see the new copy because the cookie is stored for 10 minutes.Here is an example
DOCS Atlass notice the extra 's'.
Notes:
The designer of the 404 updates reviewed and signed off.
README updates