Skip to content

RUST-577 Bump dependencies with dependabot #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

isabelatkinson
Copy link
Contributor

@isabelatkinson isabelatkinson commented May 20, 2025

Here's an example PR from my fork: isabelatkinson#5, and a patch for those changes: https://spruce.mongodb.com/version/682bbb5f2a3ef700075f76b4/tasks?page=0&sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC&variant=%5Ecompile%24.

This does the equivalent of running cargo update; i.e., it doesn't update the dependencies in Cargo.toml, as doing so may bump to a new major version requiring code changes and/or an MSRV update. Dependabot does allow configuring minor version bumps only, but this breaks for pre-1.0 dependencies, for which a minor version update (e.g. 0.2.0->0.3.0) can include breaking changes.

I chose a weekly cadence as I expect we should be able to merge these PRs as-is most of the time, but we can revisit if it becomes disruptive.

allow:
- dependency-type: all
ignore:
- dependency-name: "mongocrypt-sys"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependabot gets confused by the path dependency (https://github.com/mongodb/libmongocrypt-rust/blob/c333ab07e36f72ac3a4fd8c9f1ff96a98e60ea3e/mongocrypt/Cargo.toml#L21), so we'll need to update this dependency manually

@isabelatkinson isabelatkinson marked this pull request as ready for review May 20, 2025 20:13
@isabelatkinson isabelatkinson requested a review from a team as a code owner May 20, 2025 20:13
@isabelatkinson isabelatkinson requested a review from abr-egn May 20, 2025 20:13
@isabelatkinson isabelatkinson merged commit 208d037 into mongodb:main May 20, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants