Skip to content

PYTHON-5339 Clean up GitHub PR definitions in Evergreen Project #2331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 6, 2025

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented May 2, 2025

Use the "pr" tag in the generated config as our only patch definition. Produces 128 tasks.

Server version tests:

image

Standard tests:

image

Non standard tests:

image

@blink1073
Copy link
Member Author

evergreen retry

@blink1073 blink1073 requested a review from NoahStapp May 6, 2025 15:06
@blink1073 blink1073 marked this pull request as ready for review May 6, 2025 15:06
CONTRIBUTING.md Outdated
@@ -225,6 +225,7 @@ the pages will re-render and the browser will automatically refresh.
- Run `just run-tests` to run the tests in an appropriate Python environment.
- When done, run `just teardown-tests` to clean up and `just stop-server` to stop the server.

foo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unintentionally included I assume.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@blink1073 blink1073 requested a review from NoahStapp May 6, 2025 15:14
Copy link
Contributor

@NoahStapp NoahStapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these the tasks that will run on every PR?

@blink1073
Copy link
Member Author

Yes

@NoahStapp
Copy link
Contributor

Yes

Can we include a slightly larger slice of our total suite, now that we've pared down what actually runs in most suites?

@blink1073
Copy link
Member Author

Total time taken is already 20 hours 18 min, is there something specific you think we're lacking?

@NoahStapp
Copy link
Contributor

Total time taken is already 20 hours 18 min, is there something specific you think we're lacking?

Having a task for each extra we have would make sense to me, to ensure we don't break anything unintentionally.

@blink1073
Copy link
Member Author

blink1073 commented May 6, 2025

| Having a task for each extra we have would make sense to me, to ensure we don't break anything unintentionally.

We're already covering the ones that use the "non-standard" tasks. The other ones don't do that because they rely on VMs or Atlas clusters.

@blink1073
Copy link
Member Author

I think mod_wsgi is the only outlier that would manually add the pr tag to, I'll do that.

@blink1073
Copy link
Member Author

That brings us to 128 tasks.

@blink1073 blink1073 requested a review from NoahStapp May 6, 2025 18:03
Copy link
Contributor

@NoahStapp NoahStapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@blink1073 blink1073 merged commit d0b0dc3 into mongodb:master May 6, 2025
64 of 66 checks passed
@blink1073 blink1073 deleted the PYTHON-5339 branch May 6, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants