-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-5339 Clean up GitHub PR definitions in Evergreen Project #2331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
evergreen retry |
CONTRIBUTING.md
Outdated
@@ -225,6 +225,7 @@ the pages will re-render and the browser will automatically refresh. | |||
- Run `just run-tests` to run the tests in an appropriate Python environment. | |||
- When done, run `just teardown-tests` to clean up and `just stop-server` to stop the server. | |||
|
|||
foo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unintentionally included I assume.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these the tasks that will run on every PR?
Yes |
Can we include a slightly larger slice of our total suite, now that we've pared down what actually runs in most suites? |
Total time taken is already 20 hours 18 min, is there something specific you think we're lacking? |
Having a task for each extra we have would make sense to me, to ensure we don't break anything unintentionally. |
| Having a task for each extra we have would make sense to me, to ensure we don't break anything unintentionally. We're already covering the ones that use the "non-standard" tasks. The other ones don't do that because they rely on VMs or Atlas clusters. |
I think mod_wsgi is the only outlier that would manually add the pr tag to, I'll do that. |
That brings us to 128 tasks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Use the "pr" tag in the generated config as our only patch definition. Produces 128 tasks.
Server version tests:
Standard tests:
Non standard tests: