chore(ci): fix vscode test MONGOSH-2422 #2564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes VSCode testing issues by upgrading the Docker environment from Ubuntu 22.04 to 24.04 and properly implementing Node.js version management using NVM.
- Replaced Ubuntu 22.04 Dockerfile with Ubuntu 24.04 version that uses NVM for Node.js installation
- Updated build scripts to use the new Docker image and pass NODE_JS_VERSION as build argument
- Switched from apt-based Node.js installation to NVM-based installation for better version control
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/docker/ubuntu24.04-xvfb.Dockerfile | New Dockerfile using Ubuntu 24.04 with NVM-based Node.js installation |
| scripts/docker/ubuntu22.04-xvfb.Dockerfile | Removed old Ubuntu 22.04 Dockerfile |
| .evergreen/evergreen.yml.in | Updated build commands to use new Docker image with NODE_JS_VERSION argument |
| .evergreen.yml | Updated generated config with same Docker image changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gagik
changed the title
addaleax
approved these changes
Nov 3, 2025
| run_on: ubuntu2004-small | ||
| tags: ["nightly-driver"] | ||
| expansions: | ||
| node_js_version: "20.19.5" |
Collaborator
There was a problem hiding this comment.
Is VSCode still on this? I imagine we'd actually want a more recent one that roughly matches what VSCode uses
Contributor
Author
There was a problem hiding this comment.
VSCode is pretty slow at adopting Node but the latest one is actually now on 22.19.0, so I can try this 👍
gagik
force-pushed
the
gagik/fix-vscode
branch
from
f3e0628 to
0659eac
Compare
Contributor
Author
|
It's green 🥳 will do some follow-ups in VSCode: mongodb-js/vscode#1175 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes with the VSCode test with: