feat: show validation error details COMPASS-8864 COMPASS-8867 COMPASS-8865 #6797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paula-stacho
force-pushed
the
validation-errors
branch
from
9ac047e to
b574c1e
Compare
paula-stacho
changed the title
paula-stacho
force-pushed
the
validation-errors
branch
from
f6402c1 to
dcfac20
Compare
paula-stacho
force-pushed
the
validation-errors
branch
from
923c030 to
2970a30
Compare
paula-stacho
force-pushed
the
validation-errors
branch
from
daf64ca to
11cbc9a
Compare
Anemy
reviewed
Mar 21, 2025
There was a problem hiding this comment.
Nice! The insert document modal has been a place that has a lot of edge conditions, happy to see it moving to a functional component and becoming a bit easier to work with. Nice test adds and the error details are a good feature. Left a couple small questions and one or two suggestions.
| // When closing the modal. | ||
| // Remove the listeners to the BSON type validation errors in order to clean up properly. | ||
| this.props.doc.removeListener(Element.Events.Invalid, this.handleInvalid); | ||
| this.props.doc.removeListener(Element.Events.Valid, this.handleValid); | ||
| doc.removeListener(Element.Events.Invalid, handleInvalid); |
There was a problem hiding this comment.
Should these be removing the listeners in a returned function since we want this on unmount?
Also should it be using isOpen to manage the cleanup then as well since we're now keeping this modal around when isOpen is set to false?
packages/compass-crud/src/components/insert-document-dialog.tsx
Outdated
Show resolved
Hide resolved
paula-stacho
force-pushed
the
validation-errors
branch
from
e3795a9 to
2dc5a54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Combines the error details on insert, import and single update (the rest has been de-prioritized, but we might bring it in if we have extra time this week).
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes