add ci workflow for e2e testing #87
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 22bcde91af
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| with: | ||
| token: ${{ secrets.LIGHTNING_NODE_DISPATCH_TOKEN || secrets.GITHUB_TOKEN }} | ||
| repository: ${{ vars.LIGHTNING_NODE_REPO || 'cumuloglobal/lightning-node' }} | ||
| event-type: mdk-checkout-pr |
There was a problem hiding this comment.
If LIGHTNING_NODE_DISPATCH_TOKEN is not set (including all fork PRs, where secrets are unavailable), this step falls back to GITHUB_TOKEN but still targets the external cumuloglobal/lightning-node repo. GITHUB_TOKEN cannot dispatch events to another repository, so the repository-dispatch call will 401/403 and the E2E run never starts even though the workflow continues. Consider gating this step to non-fork PRs or requiring the PAT before dispatching to avoid silently skipping external E2E.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 22bcde91af
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| with: | ||
| token: ${{ secrets.LIGHTNING_NODE_DISPATCH_TOKEN || secrets.GITHUB_TOKEN }} | ||
| repository: ${{ vars.LIGHTNING_NODE_REPO || 'cumuloglobal/lightning-node' }} | ||
| event-type: mdk-checkout-pr |
There was a problem hiding this comment.
If LIGHTNING_NODE_DISPATCH_TOKEN is not set (including all fork PRs, where secrets are unavailable), this step falls back to GITHUB_TOKEN but still targets the external cumuloglobal/lightning-node repo. GITHUB_TOKEN cannot dispatch events to another repository, so the repository-dispatch call will 401/403 and the E2E run never starts even though the workflow continues. Consider gating this step to non-fork PRs or requiring the PAT before dispatching to avoid silently skipping external E2E.
Useful? React with 👍 / 👎.
No description provided.