feat: add sync_rgs method and full RGS sync before BOLT12 payments #4
Conversation
- Add sync_rgs(do_full_sync: bool) NAPI method for manual RGS sync - Perform full RGS sync before BOLT12 payments to get node announcements with addresses/features needed for onion message routing - Update ldk-node to include sync_rgs support
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bbc9312df1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
src/lib.rs
Outdated
| tokio::task::block_in_place(|| { | ||
| tokio::runtime::Handle::current().block_on(async { | ||
| self |
There was a problem hiding this comment.
sync_rgs calls tokio::task::block_in_place and Handle::current().block_on(...), which panics if the caller is not already inside a Tokio runtime. N-API methods like this are invoked from the Node.js thread, which typically has no Tokio runtime, so calling syncRgs() from JS will crash the process instead of returning a Result. Consider creating a runtime (as you do for LNURL) or routing the call onto an existing runtime so the method is safe to call from JS.
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Summary
sync_rgs(do_full_sync: bool)NAPI method for manual RGS syncContext
BOLT12 payments require onion message routing to introduction nodes in blinded paths. LDK's
DefaultMessageRouter.find_path()needs node announcement data (addresses/features) to route these messages. RGS v2 includes this data, so a full RGS sync before BOLT12 payments ensures the router has the necessary information.Test plan