fix(Token/ControllerToken): invalid transfer to the token address #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
The
transferandtransferFromfunctions were missing a security check to prevent sending tokens to the token contract's own address, which could lead to unintended behavior.Implementation
Token Contract
Added a
requirestatement in both thetransferandtransferFromfunctions to ensure that thetoaddress cannot be the token contract's own address.ControllerToken Contract
Added a
requirestatement in both thetransferandtransferFromfunctions to ensure that thetoaddress cannot be either the token contract's own address or the frontend's address.