-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zoning UI cleanup 2 #179
Zoning UI cleanup 2 #179
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is still a draft but figured I'd have a quick skim over this. If you're having issues with null
/undefined
stuff I'd be happy to go over best practices more, they can be a real bastard to work with.
Could also enable TS strict mode specifically for this file, which will yell at you like crazy at first, but once you fix all the strict null check issues it can make getting null-checking
right much easier.
1948641
to
e62df75
Compare
e62df75
to
3faf905
Compare
4e2102a
to
a951ffa
Compare
681bd34
to
e842ebe
Compare
while zoning, communicate between engine and frontend with whole region instead of individual points
c3cfae8
to
d5e6ef2
Compare
d5e6ef2
to
4b87e68
Compare
8f81b35
to
ebaab78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't reviewed all of the code but this looks fine in game.
078e0f0
to
babf3c4
Compare
Closes:
momentum-mod/game/issues/2122
momentum-mod/game/issues/2225
This PR changes the UX around point placement while zoning and updates the UI accordingly. The region menu has been updated to remove tabs for points, properties, and teleport.
Checks
feat: Add foo
,chore: Update bar
, etc...fixup
ed into my original commits.