Pakfile Explorer fixes #130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e explorer Pakfile explorer drag-drop wasn't working, where the OnDrop event wasn't getting raised. I have no idea why this fixes it, but it does, and Avalonia seems to automatically be doing the DragDropEffects.Link icon behaviour already, so removing this code doesn't affect the application in any negative way.
Idk why I was doing this, more complex and not going to be a major perf benefit unless getting used a lot.
tsa96
added
Type: Bug
Fixes two bugs: - Could get stuck in an infinite loop when moving from a directory whose path is a substring of the new directory - Would change "foo/barbaz.vtf" when moving "foo/bar.vtf"
tsa96
force-pushed
the
fix/pakfile-fixes
branch
from
e10a394 to
f51ca0a
Compare
Trying to run on UI thread is a nightmare as we're updating Content as we go, multithreading headache.
Last dep upgrade removed nullability of these
Idk why these methods got dumped at the top
tsa96
force-pushed
the
fix/pakfile-fixes
branch
from
f51ca0a to
0982d4a
Compare
| @@ -291,6 +291,22 @@ out string[]? opNoExtension | |||
| if (changes > 0) | |||
| Logger.Info($"Replaced {changes} instances of {updatedOp} with {updatedNp} in file {entry.Key}"); | |||
| } | |||
|
|
|||
| // TexData - doesn't have viewmodels (yay!) | |||
| if (oldPath.EndsWith(".vmt", cmp) && opPrefix.Equals("materials", cmp)) | |||
There was a problem hiding this comment.
Use Path.GetExtension instead.
GordiNoki
reviewed
Mar 14, 2025
| string[] npSplit = newPath.Split(separator); | ||
|
|
||
| // VMTs can reference VTFs ignoring the root directory and without the extension | ||
| oldPath = string.Join(separator, opSplit[1..]); |
There was a problem hiding this comment.
This makes oldPath and newPath empty, making line 247 throw an error on string replace. If current path doesn't use specified separator, opSplit and npSplit would become one-element arrays, and both of them are sliced off here
| // fucked. | ||
| if (directoryMatch is not null) | ||
| { | ||
| op = string.Join("/", op.Split('/')[1..]); |
There was a problem hiding this comment.
It might be more efficient to use substrings:
op = op.Substring(op.IndexOf('/') + 1);
Panzerhandschuh
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Panzer's issue with surf_arcade
Closes #49