Update Entity Rules #110
Merged
Update Entity Rules #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsa96
force-pushed
the
feat/update-entityrules
branch
2 times, most recently
from
21788ee to
3d08570
Compare
|
Most of the denied entities have no impact on gameplay. Why do we have to hassle mappers to remove them? We should only deny entities that are actually causing problems. |
Let's discuss this in #game-design, not here. |
Enum is ordered in the way we want stuff ordered in UI so `1` is "Unknown", which we don't want in the spreadsheet.
tsa96
force-pushed
the
feat/update-entityrules
branch
from
3d08570 to
0b88955
Compare
|
@Panzerhandschuh if you could check this out as well that'd be great, then can get Lumper 1.1.0 out tomorrow. Don't think the contents of the entity rules sheet needs to block this MR, we can always update entity rules in a patch release if necessary. |
Panzerhandschuh
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates from gsheet, fixes a bug where it getting the allow level wrong because I screwed up an enum in the python script