Potential fix for code scanning alert no. 89: Inefficient regular expression - #57
Merged
Conversation
…ression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
mokesano
added a commit
that referenced
this pull request
Jul 29, 2026
Potential fix for code scanning alert no. 89: Inefficient regular expression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/mokesano/lumera-frontiers/security/code-scanning/89
General fix: remove ambiguity inside quantified alternations by ensuring each alternative has a distinct prefix (or by excluding the special-token prefix from the fallback class), so the engine does not need to explore exponentially many partitions.
Best fix here (without changing behavior): in the line-1203 pattern, keep the explicit
<<0>>branch but make the fallback character class reject<, so<<0>>can only be matched by its dedicated branch. This preserves intended matching while eliminating the overlap causing catastrophic backtracking.Change needed in
public/js/lib/tinymce/plugins/codesample/plugin.js:interpolation-stringpattern at line ~1203, replace:(?:...|<<0>>|[^\\{"])*(?:...|<<0>>|[^\\{"<])*Suggested fixes powered by Copilot Autofix. Review carefully before merging.