Migrating reactor_ev to subtests.#2154
Open
sergiotarxz wants to merge 1 commit intomojolicious:mainfrom
Open
Conversation
sergiotarxz
force-pushed
the
subtests-mojo-reactor-ev
branch
2 times, most recently
from
12f6eaf to
091e893
Compare
kraih
requested review from
a team,
Grinnz,
jhthorsen,
kraih and
marcusramberg
kraih
reviewed
Feb 12, 2024
kraih
reviewed
Feb 12, 2024
kraih
reviewed
Feb 12, 2024
kraih
reviewed
Feb 12, 2024
sergiotarxz
force-pushed
the
subtests-mojo-reactor-ev
branch
from
091e893 to
8ab90c7
Compare
kraih
reviewed
Feb 14, 2024
Member
|
For reviewers, hiding whitespace changes makes these PRs a lot easier to review. |
sergiotarxz
force-pushed
the
subtests-mojo-reactor-ev
branch
5 times, most recently
from
134974f to
87e880e
Compare
kraih
reviewed
Feb 16, 2024
sergiotarxz
force-pushed
the
subtests-mojo-reactor-ev
branch
3 times, most recently
from
e27ced9 to
bbcc6b0
Compare
sergiotarxz
force-pushed
the
subtests-mojo-reactor-ev
branch
from
bbcc6b0 to
a3c4dd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrating reactor_ev.t to subtests.
I have tried to split the tests to use their own variables but I was not able for most of them, I am creating this pull request to see if it can fit like it is and if not to attempt to get advice to do it better.
Motivation
Issue #1520
References
#1520