Skip to content

Commit

Permalink
Corrections based on review
Browse files Browse the repository at this point in the history
- Remove `deephaven-js-plugins` reference that is no longer valid
- Remove START_OPTS that I accidentally left in there
- Fix typo wtih => with
  • Loading branch information
mofojed committed Nov 16, 2023
1 parent 0359584 commit d9b8ef7
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -134,12 +134,10 @@ pip install --force-reinstall --no-deps <deephaven-plugins-path>/plugins/*/dist/

##### Start deephaven-core

START_OPTS="-Ddeephaven.jsPlugins.@deephaven/js-plugin-matplotlib=/home/bender/dev/deephaven/iris-oss/deephaven-plugins/plugins/matplotlib/src/js -Ddeephaven.jsPlugins.@deephaven/js-plugin-ui=/home/bender/dev/deephaven/iris-oss/deephaven-plugins/plugins/ui/src/js"

Finally, start up Deephaven with the appropriate js-plugin flags using the path to your local deephaven-js-plugins repo. For example, to start wtih the matplotlib and plotly plugins, start the server with the following command:
Finally, start up Deephaven with the appropriate js-plugin flags using the path to your deephaven-plugins repo. For example, to start with the matplotlib and plotly plugins, start the server with the following command:

```
START_OPTS="-Ddeephaven.jsPlugins.@deephaven/js-plugin-matplotlib=<deephaven-plugins-path>deephaven-js-plugins/plugins/matploltib/src/js -Ddeephaven.jsPlugins.@deephaven/js-plugin-plotly=<deephaven-plugins-path>deephaven-js-plugins/plugins/plotly/src/js" ./gradlew server-jetty-app:run
START_OPTS="-Ddeephaven.jsPlugins.@deephaven/js-plugin-matplotlib=<deephaven-plugins-path>/plugins/matploltib/src/js -Ddeephaven.jsPlugins.@deephaven/js-plugin-plotly=<deephaven-plugins-path>/plugins/plotly/src/js" ./gradlew server-jetty-app:run
```

The Deephaven IDE can then be opened at http://localhost:10000/ide/, with your plugins ready to use.

0 comments on commit d9b8ef7

Please sign in to comment.