Skip to content

Commit

Permalink
docs: Fix the demo script
Browse files Browse the repository at this point in the history
- Some results were being assigned to a new variable instead of replacing the existing `result` panel
- Add explicit wrapping around text with icon in ui.item case. Created ticket to automatically wrap raw nodes: deephaven#353
- Fix hist_demo. You cannot pass non-hashable objects into a set; in this case we were passing in a dict to the set of dependencies. Need to use an array instead
  - Should we even bother allow passing in a `set` because of stuff like this?
  • Loading branch information
mofojed committed Mar 12, 2024
1 parent cea544b commit 9a44ae4
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions docker/data/storage/notebooks/DEMO.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def picker():
)


p = picker()
result = picker()
```

## Using Tables
Expand Down Expand Up @@ -226,7 +226,7 @@ def hist_demo(source, column):
x=column,
nbins=bin_count,
),
{bin_count, hist_range, source, column},
[bin_count, hist_range, source, column],
)

return [
Expand Down Expand Up @@ -322,7 +322,7 @@ def table_tabs(source):
return ui.tabs(
ui.tab_list(
ui.item("Unfiltered", key="Unfiltered"),
ui.item(ui.icon("vsGithubAlt"), "CAT", key="CAT"),
ui.item(ui.icon("vsGithubAlt"), ui.text("CAT"), key="CAT"),
ui.item("DOG", key="DOG"),
),
ui.tab_panels(
Expand Down

0 comments on commit 9a44ae4

Please sign in to comment.