Skip to content

fix(mofa-cards): remove real artist names from style prompts#61

Open
BH3GEI wants to merge 1 commit into
mainfrom
fix/style-prompt-safety
Open

fix(mofa-cards): remove real artist names from style prompts#61
BH3GEI wants to merge 1 commit into
mainfrom
fix/style-prompt-safety

Conversation

@BH3GEI

@BH3GEI BH3GEI commented May 19, 2026

Copy link
Copy Markdown
Member

Summary

  • Replace specific artist references (丰子恺/Feng Zikai, 老吴画画/Liu Shuyong) with generic style descriptors (童趣水墨, 民国文人水墨) in card style prompts
  • Fixes OpenAI content safety system rejections when generating cards with these styles
  • All visual style details and descriptions preserved — only names removed

Files changed

  • mofa-cards/styles/feng-zikai.toml — "Feng Zikai 丰子恺" → "童趣水墨"
  • mofa-cards/styles/laoshu.toml — "Laoshu 老吴画画" → "民国文人水墨"

Test plan

  • All 8 card styles tested on macmini2 with gpt-image-2, all pass
  • feng-zikai and laoshu no longer trigger safety rejections

Replace specific artist references (丰子恺/Feng Zikai, 老吴画画/Liu Shuyong)
with generic style descriptors (童趣水墨, 民国文人水墨) to avoid triggering
OpenAI's content safety system. All style details and visual descriptions
are preserved — only names are removed.
Copilot AI review requested due to automatic review settings May 19, 2026 11:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR replaces real artist names (Feng Zikai / 丰子恺 and 老吴画画 / Liu Shuyong) in two card style prompt files with generic Chinese style descriptors (童趣水墨, 民国文人水墨). The goal is to avoid OpenAI's content safety system rejecting image generations that reference named living/real artists, while preserving all visual style descriptions.

Changes:

  • Renamed display_name and replaced artist references in feng-zikai.toml with 童趣水墨.
  • Replaced 老吴画画 / Liu Shuyong references in laoshu.toml with 民国文人水墨 / Minimal Folk Ink-Wash, including removing engraved seal text referencing the artist.
  • Preserved all visual details (colors, composition, typography, brush stroke descriptions).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
mofa-cards/styles/feng-zikai.toml Replaces "Feng Zikai (丰子恺)" references with generic "童趣水墨" descriptor across all three variants.
mofa-cards/styles/laoshu.toml Replaces "老吴画画 / Liu Shuyong" references with "民国文人水墨 / Minimal Folk Ink-Wash" and removes engraved seal text naming the artist.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants