Make Int <-> UInt conversions explicit #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: raju <[email protected]>
ehsanmok
reviewed
Nov 17, 2025
| out_tensor, | ||
| a_tensor, | ||
| SIZE, | ||
| UInt(SIZE), |
Collaborator
There was a problem hiding this comment.
I think would be easier to do it at the initialization alias SIZE: UInt = ....
ehsanmok
reviewed
Nov 17, 2025
| ): | ||
| global_i = block_dim.x * block_idx.x + thread_idx.x | ||
| local_i = thread_idx.x | ||
| global_i = Int(block_dim.x * block_idx.x + thread_idx.x) |
Collaborator
There was a problem hiding this comment.
We'll need to change this once we complete centralizing to Int.
ehsanmok
approved these changes
Nov 17, 2025
Collaborator
ehsanmok
left a comment
ehsanmok
left a comment
There was a problem hiding this comment.
LGTM! A couple of minor points.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on the work started by @rajuptvs in PR #123, this converts all implicit Int <-> UInt conversions to explicit typecasts. This is important to migrate over now, because the latest Mojo and MAX nightlies make this a compilation error, rather than a warning. I tested each puzzle problem and solution, and with these casts each now works on the latest nightlies.
Where possible, I tried to have the casts take place in code that we provided to each person attempting to solve a problem, so that they didn't need to account for them in the code they'd write. I'm also trying to keep in mind that we may standardize on Int for many of these interfaces, so attempted to keep the code changes minimal for when that migration may occur.
Fixes #119