feat: Render view options / Automatic cache clean #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just for reference: SideBySide: 
Combined: 
|
|
This looks great! I'll try to give it a test soon 🙂 |
|
It seems if there are diffs already in the cache and the renderer setting is changed then you don't see the change since it's still loading the cached diffs. I tried clearing the cache but that didn't help.. it's possible the new cache clearing mechanism isn't working (or I haven't enabled it somehow?). Loading diffs on an object where they haven't been cached yet works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to change the renderer from strictly "Inline" to "SideBySide" and "Combined". Mostly because side by side is more how my brain wants to look at diffs. Re: #153
I also tied in cleaning up the cache directory on site_refresh, since there are currently no mechanisms to do that. Re: #152