add overloads for registerResource method in McpServer class #661
+12
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Without the overload, TypeScript struggles to distinguish between
ReadResourceCallback
andReadResourceTemplateCallback
.How Has This Been Tested?
Locally modified the sdk and verified the typings work as expected with this change.
Breaking Changes
None.
Types of changes
Checklist
Additional context
Here's a real-world example that has issues without this change:
Here's the type error:
I can manually add
satisfies ReadResourceTemplateCallback
to the callback, but that should not be necessary and this change removes the issue entirely.