Update protocol version #410
Open
+32
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This fixes modelcontextprotocol#378 * In types.ts - set LATEST_PROTOCOL_VERSION to "2025-03-26" - add "2025-03-26" to SUPPORTED_PROTOCOL_VERSIONS * In auth.test.ts - in test "returns metadata when discovery succeeds" - expect "MCP-Protocol-Version" to be "2025-03-26"
* Added types.test.ts - "should have correct latest protocol version" - "should have correct supported protocol versions"
* tidy types.test.ts
ihrpr
requested changes
Apr 28, 2025
There was a problem hiding this comment.
Thank you for working on this! Please can we have tests for version negotiations. Ideally we test:
- old protocol server, new client
- old protocol client, new server
It seems as if the bases are covered by the current crop of client and server tests. If you see a gap, I'm happy to close it. Server version-handling tests
Client version-handling tests
|
Those tests have loads of mocking, I think if we can just check manually if all works fine for both of the cases that would be great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
StreamableHttp is available in the current release of the SDK and people are finding that returning the newest protocol version from their servers can cause a failure to connect.
How Has This Been Tested?
Unit and integration tests pass. Lint has no errors.
Breaking Changes
Nope.
Types of changes
Checklist
Additional context