Skip to content

comment: fix stateless comments that no session-id is included in any responses #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

botengyao
Copy link
Contributor

@botengyao botengyao commented Apr 25, 2025

Motivation and Context

Fixed the comments for stateless mode.
CMIIR - My understanding of the stateless mode in the code, the sessionIdGenerator is not defined, and then there will be no session id for any response.

How Has This Been Tested?

No need to test.

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@botengyao
Copy link
Contributor Author

cc @ihrpr @jspahrsummers

Copy link
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@ihrpr ihrpr merged commit 7e18c70 into modelcontextprotocol:main Apr 28, 2025
2 checks passed
@botengyao
Copy link
Contributor Author

Thanks @ihrpr! I guess we could need a squash to merge the PR to repo so that there will be one commit for each PR.

@Junjun13910

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants