Skip to content

Bump to version 1.10.0 #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2025

Conversation

cliffhall
Copy link
Contributor

@cliffhall cliffhall commented Apr 10, 2025

In package.json

  • set version to 1.10.0

Motivation and Context

Streamable HTTP Transport is available and we need that for a PR in the inspector that supports it.

How Has This Been Tested?

Local build, test, lint.

Breaking Changes

Nope.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Version update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Copy link

@tadasant tadasant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I think we'd want a package-lock.json bump as well right?

May be best to wait for @modelcontextprotocol/typescript-sdk to chime in here, don't want to mess up a release

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "@modelcontextprotocol/sdk",
"version": "1.9.0",
"version": "1.9.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like most recent bumps have been minor version bumps rather than patch bumps, and adding Streamable support feels more like a backwards-compatible new-feature (minor version) addition than a bugfix (patch). Should this be 1.10.0 then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@cliffhall cliffhall changed the title Bump to version 1.9.1 Bump to version 1.10.0 Apr 10, 2025
@cliffhall cliffhall requested a review from tadasant April 10, 2025 23:31
Copy link
Member

@jspahrsummers jspahrsummers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I agree on using a minor version here. Bumping package-lock.json isn't critical, since it doesn't affect distribution (only local dev, where it will update next time someone runs npm install).

@jspahrsummers jspahrsummers merged commit c3adee2 into modelcontextprotocol:main Apr 11, 2025
2 checks passed
@jspahrsummers
Copy link
Member

Sorry, but let's actually wait on cutting a release until the new transport work actually stabilizes. Will defer to @ihrpr on calling that moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants