Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update router.ts to make sure that the URL concatenation works properly #168

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

localden
Copy link

@localden localden commented Mar 1, 2025

Addresses #167 as using anything with more complex definitions of the issuer results in incorrect endpoint URLs.

Motivation and Context

Ensures that the generated auth metadata is correct.

How Has This Been Tested?

Local machine with a local copy of the modified SDK.

Breaking Changes

On the surface - no, but always worth checking if someone took a dependency on the incorrect calculated endpoints.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant