chore: sync spec types from upstream (commit 35fa160) #1226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates spec.types.ts from upstream and fixes compatibility issues:
- Make requestId optional in CancelledNotificationParams (per spec change for task cancellation)
- Make id optional in JSONRPCErrorSchema (per JSON-RPC spec for parse errors)
- Handle optional id in protocol.ts when routing error responses
- Add type compatibility tests for new task-related types
- Add Fix helpers for spec/SDK type differences:
- FixSDKTaskParams: SDK's task.ttl allows null, spec's TaskMetadata doesn't
- FixSpecJSONRPCResponse: Spec's JSONRPCResponse is now a union
- DeepAddIndexSignature: Handle spec's object vs SDK's {[x:string]:unknown}
- Update MISSING_SDK_TYPES for spec-only types
Closes #1152
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates spec.types.ts from upstream and fixes compatibility issues:
Closes #1152
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context