Skip to content

remove info level logging message and use debug instead #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Sources/MCP/Base/Transports/HTTPClientTransport.swift
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ public actor HTTPClientTransport: Transport {
streamingTask = Task { await startListeningForServerEvents() }
}

logger.info("HTTP transport connected")
logger.debug("HTTP transport connected")
}

/// Disconnects from the transport
Expand Down Expand Up @@ -180,7 +180,7 @@ public actor HTTPClientTransport: Transport {
initialSessionIDContinuation?.resume()
initialSessionIDContinuation = nil

logger.info("HTTP clienttransport disconnected")
logger.debug("HTTP clienttransport disconnected")
}

/// Sends data through an HTTP POST request
Expand Down Expand Up @@ -440,7 +440,7 @@ public actor HTTPClientTransport: Transport {
"Initial sessionID already available. Proceeding with SSE streaming task immediately."
)
} else {
logger.info(
logger.trace(
"Proceeding with SSE connection attempt; sessionID is nil. This might be expected for stateless servers or if initialize hasn't provided one yet."
)
}
Expand Down
12 changes: 6 additions & 6 deletions Sources/MCP/Base/Transports/NetworkTransport.swift
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ import Logging

// Reset reconnect attempt counter on successful connection
reconnectAttempt = 0
logger.info("Network transport connected successfully")
logger.debug("Network transport connected successfully")
continuation.resume()

// Start the receive loop after connection is established
Expand Down Expand Up @@ -466,7 +466,7 @@ import Logging
{
// Try to reconnect with exponential backoff
reconnectAttempt += 1
logger.info(
logger.debug(
"Attempting reconnection after \(context) (\(reconnectAttempt)/\(reconnectionConfig.maxAttempts))..."
)

Expand Down Expand Up @@ -509,7 +509,7 @@ import Logging

connection.cancel()
messageContinuation.finish()
logger.info("Network transport disconnected")
logger.debug("Network transport disconnected")
}

/// Sends data through the network connection
Expand Down Expand Up @@ -626,7 +626,7 @@ import Logging

// Check connection state
if connection.state != .ready {
logger.info("Connection no longer ready, exiting receive loop")
logger.warning("Connection no longer ready, exiting receive loop")
break
}
}
Expand Down Expand Up @@ -676,7 +676,7 @@ import Logging
&& reconnectAttempt < reconnectionConfig.maxAttempts
{
reconnectAttempt += 1
logger.info(
logger.warning(
"Network connection lost, attempting reconnection (\(reconnectAttempt)/\(reconnectionConfig.maxAttempts))..."
)

Expand Down Expand Up @@ -727,7 +727,7 @@ import Logging
{
// Similar reconnection logic for other errors
reconnectAttempt += 1
logger.info(
logger.warning(
"Error during receive, attempting reconnection (\(reconnectAttempt)/\(reconnectionConfig.maxAttempts))..."
)

Expand Down
4 changes: 2 additions & 2 deletions Sources/MCP/Base/Transports/StdioTransport.swift
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ import struct Foundation.Data
try setNonBlocking(fileDescriptor: output)

isConnected = true
logger.info("Transport connected successfully")
logger.debug("Transport connected successfully")

// Start reading loop in background
Task {
Expand Down Expand Up @@ -181,7 +181,7 @@ import struct Foundation.Data
guard isConnected else { return }
isConnected = false
messageContinuation.finish()
logger.info("Transport disconnected")
logger.debug("Transport disconnected")
}

/// Sends a message over the transport.
Expand Down
20 changes: 10 additions & 10 deletions Sources/MCP/Client/Client.swift
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ public actor Client {
self.connection = transport
try await self.connection?.connect()

await logger?.info(
await logger?.debug(
"Client connected", metadata: ["name": "\(name)", "version": "\(version)"])

// Start message handling loop
Expand Down Expand Up @@ -216,7 +216,7 @@ public actor Client {
break
}
} while true
await self.logger?.info("Client message handling loop task is terminating.")
await self.logger?.debug("Client message handling loop task is terminating.")
}

// Automatically initialize after connecting
Expand All @@ -225,7 +225,7 @@ public actor Client {

/// Disconnect the client and cancel all pending requests
public func disconnect() async {
await logger?.info("Initiating client disconnect...")
await logger?.debug("Initiating client disconnect...")

// Part 1: Inside actor - Grab state and clear internal references
let taskToCancel = self.task
Expand All @@ -242,26 +242,26 @@ public actor Client {
for (_, request) in pendingRequestsToCancel {
request.resume(throwing: MCPError.internalError("Client disconnected"))
}
await logger?.info("Pending requests cancelled.")
await logger?.debug("Pending requests cancelled.")

// Cancel the task
taskToCancel?.cancel()
await logger?.info("Message loop task cancellation requested.")
await logger?.debug("Message loop task cancellation requested.")

// Disconnect the transport *before* awaiting the task
// This should ensure the transport stream is finished, unblocking the loop.
if let conn = connectionToDisconnect {
await conn.disconnect()
await logger?.info("Transport disconnected.")
await logger?.debug("Transport disconnected.")
} else {
await logger?.info("No active transport connection to disconnect.")
await logger?.debug("No active transport connection to disconnect.")
}

// Await the task completion *after* transport disconnect
_ = await taskToCancel?.value
await logger?.info("Client message loop task finished.")
await logger?.debug("Client message loop task finished.")

await logger?.info("Client disconnect complete.")
await logger?.debug("Client disconnect complete.")
}

// MARK: - Registration
Expand Down Expand Up @@ -468,7 +468,7 @@ public actor Client {

// Check if there are any requests to send
guard !requests.isEmpty else {
await logger?.info("Batch requested but no requests were added.")
await logger?.debug("Batch requested but no requests were added.")
return // Nothing to send
}

Expand Down
4 changes: 2 additions & 2 deletions Sources/MCP/Server/Server.swift
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ public actor Server {
registerDefaultHandlers(initializeHook: initializeHook)
try await transport.connect()

await logger?.info(
await logger?.debug(
"Server started", metadata: ["name": "\(name)", "version": "\(version)"])

// Start message handling loop
Expand Down Expand Up @@ -227,7 +227,7 @@ public actor Server {
await logger?.error(
"Fatal error in message handling loop", metadata: ["error": "\(error)"])
}
await logger?.info("Server finished", metadata: [:])
await logger?.debug("Server finished", metadata: [:])
}
}

Expand Down