Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The completions capability is the only one without a ServerCapabilities flag, which doesn't make sense as not all servers will support it, and clients should be able to query that up front to avoid calling the method. See #157.
How Has This Been Tested?
Not yet no. It's relatively trivial and aligns with the capability flags. I'll implement this in mcpdotnet if/when the PR is merged.
Breaking Changes
In principle yes, as servers should now expose the
completions
capability explicitly. After this change, clients that query servers may assume that a server not exposing the capability does not support it. In practice, this capability is so tightly coupled to server documentation (as there is no mechanism for servers to communicate what completion parameters they support) that clients will likely be hardcoded to use completions with specific servers, making this a breaking change in theory only.Types of changes
Checklist
Additional context