feat(auth): CredentialStore trait #542
Merged
+119
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
T-dependencies
alexhancock
force-pushed
the
alexhancock/credential-store
branch
from
aec2b30 to
adb0f89
Compare
alexhancock
changed the title
alexhancock
force-pushed
the
alexhancock/credential-store
branch
2 times, most recently
from
36ef601 to
c3e6d71
Compare
jamadeo
reviewed
Nov 14, 2025
| rustdoc-args = ["--cfg", "docsrs"] | ||
|
|
||
| [dependencies] | ||
| async-trait = "0.1.89" |
Collaborator
There was a problem hiding this comment.
not sure how big a concern it is to have this, but if you want to avoid adding this dependency you can have the trait return Futures
Collaborator
There was a problem hiding this comment.
I often use this dependency and I am planning to introduce it in the future to make the code more concise. Do you want to change other implementations to this dependency implementation as well？
Contributor
Author
There was a problem hiding this comment.
Yes, we can use it more - it seems nice
alexhancock
force-pushed
the
alexhancock/credential-store
branch
from
c3e6d71 to
a9b1962
Compare
jamadeo
previously approved these changes
Nov 14, 2025
alexhancock
dismissed stale reviews from jokemanfire and jamadeo
via
479c0ce
alexhancock
force-pushed
the
alexhancock/credential-store
branch
from
a9b1962 to
479c0ce
Compare
jamadeo
approved these changes
Nov 17, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the concept of a configurable
CredentialStoreforAuthorizationManagerto useThe current implementation writes to
credentialsin memory. This change gives the flexibility for users ofAuthorizationManagerto provide a custom implementation that persists credentials (to keychain, disk, etc).There is no change to default behavior, as a default implementation is provided which does the same as now (
InMemoryCredentialStore)Motivation
The motivation came from this bug report to goose that new refresh tokens sent from the server during token exchange were not being saved/used block/goose#5259
We store access tokens and refresh tokens via
keyring, but we only did it on the initial auth and previously had no way to be informed of new refresh tokens received whenrmcpexchanges tokens.This allows for a provided
CredentialStoreto always load/save/clear token information from the storage mechanism of choice, and will fix block/goose#5259