-
Notifications
You must be signed in to change notification settings - Fork 244
example: add example in progress #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
i see the "simualte getting from a stream" but to really test, i would create a stream and process the resulting stream |
after that is added and you run the test, you should be able to see the return inconsistency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I was able to verify/successfully run the example @schwifty-brows via ![]() Were you running into something different than me? |
Yes check out the issues here
#262
…________________________________
From: Alex Hancock ***@***.***>
Sent: Friday, June 20, 2025 11:51:28 AM
To: modelcontextprotocol/rust-sdk ***@***.***>
Cc: Matthew Schneid ***@***.***>; Mention ***@***.***>
Subject: Re: [modelcontextprotocol/rust-sdk] example: add example in progress (PR #271)
[https://avatars.githubusercontent.com/u/427516?s=20&v=4]alexhancock left a comment (modelcontextprotocol/rust-sdk#271)<#271 (comment)>
I was able to verify/successfully run the example @schwifty-brows<https://github.com/schwifty-brows> via python3 progress_test_client.py in examples/clients/scripts
Screenshot.2025-06-20.at.11.49.45.AM.png (view on web)<https://github.com/user-attachments/assets/e92779cb-fed3-4b71-abf8-a8c37277b52e>
Were you running into something different than me?
—
Reply to this email directly, view it on GitHub<#271 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BLLRQDZC5LMU4LBBIKLHCRT3EQUYBAVCNFSM6AAAAAB7TD2326VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSOJSGEYTSOJQHE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
I think it is not rmcp's problem , I think it should be your business flow problem @schwifty-brows . And I have tested all the transport. The current example file structure is not very good. In fact, this example is better placed in an integration test. I will modify this structure in another pr. @alexhancock |
how should we be sending SSE messages back? the progress notification is meant to do this, but running a simple example does not consistently work |
I really find it difficult to reproduce the abnormal scenario you mentioned. In the example, I should have provided a relatively simple example to send progress notifications from the server and obtain notification messages from the client. If it is a problem with the basic components of MCP SDK, then I believe that integration testing can definitely reproduce it (after excluding business interference). Could you please try to provide test cases that can be reproduced after excluding business impact. |
maybe i am missing something (i probably am) but in the code example, i dont see anything like this i have a tool definition like so
|
This part of the example server here seems relevant, and very similar to the Does that make sense? Or if not maybe it's just github communication tripping me up from understanding. I would be happy to jump on a quick video call if you want tomorrow to discuss/get clear and identify any required improvements at the SDK level. |
Hey @alexhancock i think that would be a great idea! Let me know your availability and I can walk you through the real world use case here. |
@schwifty-brows How about 10am US eastern tomorrow? Email me (address on my profile) and we can set a meet. |
@schwifty-brows @jokemanfire I think it may be a client difference... When I run
However when I use the MCP inspector as another client to test with by running
and connect to it via
I see this when I run the stream processor tool I only see one progress notification despite it processing 13 records. This is similar to what @schwifty-brows reproduces with his test client: @jokemanfire Any ideas? |
It does seem to be related to the client, I will take a look at the inspector and compare the implementation differences. |
I have add log in inspector , I can make sure the mcpProxy recived the progress data, the problem should in inspector's front end.
|
Hello @olaservo If you have time, can you help me take a look? |
So just to be clear, this is looking to everyone now like a client only issue? @schwifty-brows Did you repro this only with inspector, or with a client in your actual codebase as well? |
Sorry for the update, the issue may be due to differences in the implementation of typescript-sdk. |
@schwifty-brows Did this ever work for you with a different client? |
Motivation and Context
add a example to introduce progress
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context