-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix: memory leak and exit problems #586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PWZER
wants to merge
5
commits into
modelcontextprotocol:main
Choose a base branch
from
PWZER:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+757
−710
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
dfa7c6a
Fix: SseServerTransport.handle_sse never ends and can lead to memory …
PWZER 1917066
update examples
PWZER 9cd4572
use client_close_handler_callable for connect_sse
PWZER fbe6b06
fix pyright
PWZER 0090583
Fix: fastmcp exit stuck
PWZER File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -32,6 +32,7 @@ async def handle_sse(request): | |||||
""" | ||||||
|
||||||
import logging | ||||||
from collections.abc import Callable | ||||||
from contextlib import asynccontextmanager | ||||||
from typing import Any | ||||||
from urllib.parse import quote | ||||||
|
@@ -43,7 +44,7 @@ async def handle_sse(request): | |||||
from sse_starlette import EventSourceResponse | ||||||
from starlette.requests import Request | ||||||
from starlette.responses import Response | ||||||
from starlette.types import Receive, Scope, Send | ||||||
from starlette.types import Message, Receive, Scope, Send | ||||||
|
||||||
import mcp.types as types | ||||||
|
||||||
|
@@ -79,7 +80,13 @@ def __init__(self, endpoint: str) -> None: | |||||
logger.debug(f"SseServerTransport initialized with endpoint: {endpoint}") | ||||||
|
||||||
@asynccontextmanager | ||||||
async def connect_sse(self, scope: Scope, receive: Receive, send: Send): | ||||||
async def connect_sse( | ||||||
self, | ||||||
scope: Scope, | ||||||
receive: Receive, | ||||||
send: Send, | ||||||
callback: Callable[[], None] | None = None, | ||||||
): | ||||||
if scope["type"] != "http": | ||||||
logger.error("connect_sse received non-HTTP request") | ||||||
raise ValueError("connect_sse can only handle HTTP requests") | ||||||
|
@@ -120,9 +127,19 @@ async def sse_writer(): | |||||
} | ||||||
) | ||||||
|
||||||
async def client_close_handler(message: Message) -> None: | ||||||
await read_stream_writer.aclose() | ||||||
await write_stream_reader.aclose() | ||||||
del self._read_stream_writers[session_id] | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
if callback: | ||||||
callback() | ||||||
logger.debug(f"Closed SSE session with ID: {session_id}") | ||||||
|
||||||
async with anyio.create_task_group() as tg: | ||||||
response = EventSourceResponse( | ||||||
content=sse_stream_reader, data_sender_callable=sse_writer | ||||||
content=sse_stream_reader, | ||||||
data_sender_callable=sse_writer, | ||||||
client_close_handler_callable=client_close_handler, # type: ignore[arg-type] | ||||||
) | ||||||
logger.debug("Starting SSE response task") | ||||||
tg.start_soon(response, scope, receive, send) | ||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes,
sse-starlette
supportsclient_close_handler_callable
since version 2.3.0.