Skip to content

Fix async callable object tools #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stephanlensky
Copy link

Makes detection of asynchronous functions more robust in Tool.from_function, allowing usage of asynchronous callable objects, e.g.

class MyAsyncTool:
    def __init__(self):
        self.__name__ = "MyAsyncTool"

    async def __call__(self, x: int) -> int:
        return x * 2

manager = ToolManager()
tool = manager.add_tool(MyAsyncTool())
result = await tool.run({"x": 5})  # 10

Motivation and Context

Fixes #567.

How Has This Been Tested?

Unit tests were added to verify the change.

Breaking Changes

This is a non-breaking change.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@stephanlensky stephanlensky force-pushed the stephanlensky/fix-async-callable-objects branch 2 times, most recently from 436673f to 00c730a Compare April 22, 2025 22:07
@stephanlensky stephanlensky force-pushed the stephanlensky/fix-async-callable-objects branch from 00c730a to 92d9426 Compare April 22, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tool.from_function does not handle asynchronous callable objects
1 participant