Skip to content

Fix hanging on streams when stdio_client exiting #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

LionNatsu
Copy link

@LionNatsu LionNatsu commented Apr 22, 2025

Triggers a TaskGroup cancel after reaching the finally code block.

Motivation and Context

stdin_writer in the task group hangs when pressing Ctrl+c.
Now we explicitly close the streams blocking.

How Has This Been Tested?

Tested in a new simple no-op test and a real Uvicorn Starlette application.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@LionNatsu LionNatsu changed the title Fix the TaskGroup hanging on stdin_writer when stdio_client exiting Fix hanging on streams when stdio_client exiting Apr 22, 2025
@ihrpr ihrpr added this to the r-05-25 milestone Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants