Skip to content

feat(func_metadata): expose skip_names argument #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NextFire
Copy link

@NextFire NextFire commented Apr 21, 2025

Expose func_metadata's skip_names argument in the @tool decorator and move the if param.name in skip_names: check to the top.

Motivation and Context

It allows users to ignore specific parameters, such as optional ones and especially those starting with an underscore.

My use case was to programmatically wrap a generated SDK for Spotify (from openapi-generator-cli) into an MCP server. However, the client methods included optional arguments that started with an underscore, which led to InvalidSignature exceptions.

image

How Has This Been Tested?

https://github.com/NextFire/spotify-mcp-server/tree/with-pr-fix

image

Breaking Changes

No.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

And move the `if param.name in skip_names:` check to the top

It allows users to ignore specific parameters, such as optional ones
and especially those starting with an underscore.
@NextFire NextFire force-pushed the feat/expose-skip-names branch from b65ab81 to cb0293d Compare April 21, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant