Use proper generic for Context#245
Merged
dsp-ant merged 2 commits intomodelcontextprotocol:mainfrom Mar 11, 2025
Kludex:use-proper-generic
Merged
Use proper generic for Context#245dsp-ant merged 2 commits intomodelcontextprotocol:mainfrom Kludex:use-proper-generic
dsp-ant merged 2 commits intomodelcontextprotocol:mainfrom
Kludex:use-proper-generic
Conversation
dsp-ant
approved these changes
Mar 11, 2025
Member
|
yup, we know that it's not checking in strict mode. It's on the very long to do list. Would love to get some help ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now you can use the Context with a proper lifespan state.
I suggest running a type checker in this project. I can see a lot of typing issues using Pyright on strict mode.